AdvLoggerPkg: fix AdvLoggerSerialPortLib class #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdvLoggerSerialPortLib was using a library class that was not a true library class (not defined in any .dec file or have an associated .h). This changes the library class to use the correct library class, SerialPortLib.
github-actions
bot
added
impact:breaking-change
makubacki
reviewed
Jun 23, 2023
makubacki
reviewed
Jun 23, 2023
makubacki
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Approving assuming there's not an unobvious reason the library class name was set this way.
The library appears to currently be missing in https://github.com/microsoft/mu_plus/blob/release/202302/AdvLoggerPkg/Docs/ReadMe.md
kuqin12
approved these changes
Jun 24, 2023
|
I think this one is good. I noticed that the original breakage for my use case was actually a misusage after all. But I think this change is still needed for other cases in |
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jun 29, 2023
Introduces 1 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/819d93ca1dec56cfe446f5c0057e7ffe56f51249">819d93</a> AdvLoggerPkg: fix AdvLoggerSerialPortLib class (<a href="https://github.com/microsoft/mu_plus/pull/268">#268</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
makubacki
referenced
this pull request
in microsoft/mu_tiano_platforms
Jun 29, 2023
Bumps Common/MU from `2023020000.1.0` to `2023020001.0.0` Introduces 1 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/819d93ca1dec56cfe446f5c0057e7ffe56f51249">819d93</a> AdvLoggerPkg: fix AdvLoggerSerialPortLib class (<a href="https://github.com/microsoft/mu_plus/pull/268">#268</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AdvLoggerSerialPortLib was using a library class that was not a true library class (not defined in any .dec file or have an associated .h).
This changes the library class to use the correct library class, SerialPortLib.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Successfully build multiple platforms and pass the newly added BaseTools change for verifying library override class names.
Integration Instructions
Any library class definitions in a dsc using AdvLoggerSerialPortLib needs to be switched to SerialPortLib.