Allow all exceptions to indicate system is offline #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
|
@microsoft-github-policy-service agree |
mikeytdisco
force-pushed
the
personal/mikeyt/RestorePingToReboot
branch
from
d1fbc73
to
477dc4d
Compare
github-actions
bot
removed
the
language:python
Flickdm
approved these changes
May 10, 2023
apop5
approved these changes
May 10, 2023
kuqin12
approved these changes
May 10, 2023
mikeytdisco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinging a QEMU virtual system doesn't work for detecting the system going offline, so the ping was removed from both the offline and online path of the test cases. However, this broke testing with real system.
Allow all exceptions to signal system not available when waiting for online or offline.
Fixes #94
How This Was Tested
Tested on the QEMU path and a physical system.
Integration Instructions
N/A