MinPlatformPkg SerialPortTerminalLib: Fixing CodeQL issue Pointless c… #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omparison of unsigned value to zero. (microsoft#282) ## Description CodeQL is reporting Pointless comparison of unsigned value to zero for a value derived from an unsigned PCD PcdDefaultTerminalType. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Ran Local CI. ## Integration Instructions N/A
github-actions
bot
added
impact:non-functional
|
review-requested: @apop5 |
@v-jaschen can you please take this to upstream edk2-platforms? We would like to make sure the upstream repos get the same benefit of the changes we make. |
makubacki
approved these changes
Nov 14, 2024
|
Hi All, this is the PR link of EDK2-platform repo: tianocore/edk2-platforms#246 |
apop5
approved these changes
Nov 14, 2024
ProjectMuBot
pushed a commit
that referenced
this pull request
Nov 14, 2024
#311) ## Description Cherry-pick Commit 03664aa #282 from release/202311 to dev/202405. CodeQL is reporting Pointless comparison of unsigned value to zero for a value derived from an unsigned PCD PcdDefaultTerminalType. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [X] Backport to release branch? ## How This Was Tested Ran Local CI including codeQL setting and pipeline codeQL build. ## Integration Instructions N/A ## upstream repo in EDK2? tianocore/edk2-platforms#246 Co-authored-by: Aaron <[email protected]> Co-authored-by: Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick Commit 03664aa #282 from release/202311 to dev/202405.
CodeQL is reporting Pointless comparison of unsigned value to zero for a value derived from an unsigned PCD PcdDefaultTerminalType.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Ran Local CI including codeQL setting and pipeline codeQL build.
Integration Instructions
N/A
upstream repo in EDK2?
tianocore/edk2-platforms#246