Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sessions config and GeoIP download failure #801

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Use sessions config and GeoIP download failure #801

merged 10 commits into from
Oct 21, 2024

Conversation

ianhelle
Copy link
Contributor

@ianhelle ianhelle commented Oct 20, 2024 •
edited
Loading

Adding user session config management
Fixed Maxmind GeoIP download.
Fixed tilookup to honor ¨progress¨ parameter

The PR has a lot of files but almost all are trivial changes. The only substantion changes are in:

  • init/mp_user_session.py (this also has unit test and documentation)
  • context/geoip.py (fixing download that now requires account id as well as api key)
  • tilookup.py (fixing progress parameter, which had been dropped)

@ianhelle
Adding user session config management
7b5a96c 
Fixed Maxmind GeoIP download.
Fixed tilookup to honor ¨progress¨ parameter
ryan-detect-dot-dev
ryan-detect-dot-dev approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@ryan-detect-dot-dev ryan-detect-dot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- minor nits and a few open questions

I like the new functionality with the user session configs. That is really useful.

Good work!

docs/source/getting_started/UserSessionConfig.rst Show resolved Hide resolved
msticpy/config/query_editor.py Show resolved Hide resolved
msticpy/init/mp_user_session.py Outdated Show resolved Hide resolved
msticpy/init/mp_user_session.py Outdated Show resolved Hide resolved
msticpy/init/mp_user_session.py Outdated Show resolved Hide resolved
msticpy/init/mp_user_session.py Outdated Show resolved Hide resolved
mypy.ini Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@ianhelle ianhelle merged commit e9adaff into main Oct 21, 2024
10 checks passed
@ianhelle ianhelle deleted the ianhelle/user_session-2024-10-19 branch October 21, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianBracq FlorianBracq FlorianBracq left review comments

@ryan-detect-dot-dev ryan-detect-dot-dev ryan-detect-dot-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianhelle @FlorianBracq @ryan-detect-dot-dev