Reintroduce previously removed exit condition in login loop + fix retry count #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econnection attempt number to avoid extra reconnection attempt.
Jeffery-Wasty
force-pushed
the
retryFix
branch
from
3d86bed
to
3515ea1
Compare
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
Jeffery-Wasty
force-pushed
the
retryFix
branch
from
bbbd81e
to
b245149
Compare
lilgreenbird
approved these changes
Sep 14, 2023
tkyc
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of Idle Connection Resiliency in 10.2, we would continually retry on transient errors, until loginTimeout was reached. This was due to the omission of an exit condition. The condition has been added back in.
As well, we were retrying one more time than we should have been, this has been adjusted.