More code clean up to fix SonarQube issues #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilgreenbird
changed the title
… over decremented (#1989) * Updated onDone with reason/comment for unecessary decrement for future reference * Added more ICR tests * Added missing brackets * Test table names needed to be unique * Drop tables within test if exist Co-authored-by: lilgreenbird <[email protected]>
* Merge dev to master for 9.2.0 release (#1506) Merge dev to master for 9.2.0 release (#1506) * fix merge * Fix #1964 by not having a static field at all. It was cleared each time anyway. * refactor a bit Co-authored-by: ulvii <[email protected]> Co-authored-by: Peter Bae <[email protected]> Co-authored-by: Milan Mimica <[email protected]>
…ion to datetime or datetime2 (#1687) * Added support for dateTimeType connection string * Added support for the dateTimeType connection string, which allows you to define how date/time values are parameterized in SQL Server. By default, for SQL Server 2008+ the "datetime2" datatype is used, where as older versions of SQL Server always use the "datetime". This allows users migrating older database application that exclusively use "datetime" datatypes to run in SQL Server compatibility modes newer than 2014. * Added unit test coverage for changes * Renamed dateTimeType to datetimeParameterType * Revert "Merge branch 'dev'" This reverts commit 416dd5e, reversing changes made to 4e8d787. * Resolved merge conflicts * Revert "Update versions to fix vulnerabilities (#1689)" This reverts commit 4e8d787. * Fixed broken merge and re-added datetimeParameterType feature The merge was corrupted and blew out most of the datetimeParameterType feature changes, so I've re-applied the changes manually. * Create Parameter.java superficial change just to trigger pipeline run * Delete SQLServerConnection.java.orig this file should not be here * Apply suggestions from code review Co-authored-by: David Engel <[email protected]> * Update src/main/java/com/microsoft/sqlserver/jdbc/Parameter.java Co-authored-by: David Engel <[email protected]> * Update src/main/java/com/microsoft/sqlserver/jdbc/Parameter.java Co-authored-by: David Engel <[email protected]> * Update src/main/java/com/microsoft/sqlserver/jdbc/SQLServerLexer.java Co-authored-by: lilgreenbird <[email protected]> Co-authored-by: David Engel <[email protected]>
tkyc
reviewed
Dec 22, 2022
| /** | ||
| * internal class name used in tracing | ||
| */ | ||
| private static final String INTERNAL_CLASSNAME = "SQLServerStatement"; |
There was a problem hiding this comment.
We can just use SQLServerStatement.class no? No need to define a string (I saw another place that did this too in the PR)
tkyc
approved these changes
Dec 22, 2022
Jeffery-Wasty
approved these changes
Dec 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also some coding standard fixes