Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The getters and setters for useBulkCopyForBatchInsert is not available for SQLServerConnectionPoolProxy #2245

Closed
PriyadharshiniP opened this issue Nov 1, 2023 · 1 comment · Fixed by #2277
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.

Comments

@PriyadharshiniP
Copy link
Contributor

PriyadharshiniP commented Nov 1, 2023

Driver version

ms-sql-jdbc-12.4.2jre11.jar

SQL Server version

Microsoft SQL Server 2019 (RTM-CU18) (KB5017593) - 15.0.4261.1 (X64) Sep 12 2022 15:07:06 Copyright (C) 2019 Microsoft Corporation Developer Edition (64-bit) on Windows 10 Pro 10.0 (Build 19045: )

Client Operating System

Windows

JAVA/JVM version

Java 17

Table schema

NA

Problem description

The comments in the SQLServerConnectionPoolProxy and SQLServerConnection classes specify that the public functionalities of both classes should remain the same.
For SQLServerConnectionPoolProxy, the getters and setters for useBulkCopyForBatchInsert are absent.

While this is mentioned in the comments of the SQLServerConnectionPoolProxy,
This class's public functions need to be kept identical to the SQLServerConnection's.

Since we use a connection pool and don't see another way to get the underlying SQLServerConnection from the SQLServerConnectionPoolProxy to set the bulk copy flag only while executing specific batch inserts. We would like to set the bulk copy only when running specific bulky insert statements.

Expected behavior

Provide getters and setters for useBulkCopyForBatchInsert in SQLServerConnectionPoolProxy similar to SQLServerConnection.

Actual behavior

SQLServerConnectionPoolProxy doesn't have setters and getters for useBulkCopyForBatchInsert but available in SQLServerConnection.

Error message/stack trace

NA

Any other details that can be helpful

NA

JDBC trace logs

NA

@tkyc
Copy link
Member

tkyc commented Nov 2, 2023

Looks reasonable to do, marking as enhancement. I'll let you know if/when this is taken up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.
Projects
Status: Closed Issues
2 participants