Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Ignore Invalid Tokens #4412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Always Ignore Invalid Tokens #4412

wants to merge 2 commits into from

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Jul 24, 2024

Description

This updates the code to always ignore invalid tokens, instead of dropping packets with invalid Retry tokens. This is necessary because it's possible the client sends a NEW_TOKEN token from a different server to you, which you then interpret as a bad RETRY token. This would result in all connection attemps from that client in this case to fail. The best answer is to just ignore these bad tokens.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner July 24, 2024 23:49
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (db86b92) to head (515f380).
Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
src/core/connection.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4412      +/-   ##
==========================================
- Coverage   85.36%   85.05%   -0.31%     
==========================================
  Files          56       56              
  Lines       15457    15447      -10     
==========================================
- Hits        13195    13139      -56     
- Misses       2262     2308      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks added the Area: Core Related to the shared, core protocol logic label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant