Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker multistage build for xdp support #4238

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Apr 12, 2024

Description

Installing libxdp/libbpf conflicts libc6 version for arm cross compile toolset.
Multistage build to avoid installing toolset on one image.

Testing

Locally passed docker build --target ${arch|-build and pwsh ./scripts/build.ps1 -Arch ${arch} for each arch
Ubuntu 20.04 cannot build xdp related source code as bpf.h (linux-libc-dev) header doesn't have required struct declaration.
This can be avoided by apt-get upgrade linux-libc-dev, but not good from CI/CD point of view.
 

Documentation

N/A

@ami-GS ami-GS requested a review from a team as a code owner April 12, 2024 19:23
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (c60d710) to head (a2b6b96).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4238      +/-   ##
==========================================
- Coverage   85.56%   85.40%   -0.17%     
==========================================
  Files          56       56              
  Lines       15357    15357              
==========================================
- Hits        13140    13115      -25     
- Misses       2217     2242      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ami-GS
Copy link
Contributor Author

ami-GS commented Apr 12, 2024

docker pull failed.
Is the docker image available once this PR is merged?
image

@ami-GS ami-GS enabled auto-merge (squash) April 15, 2024 21:24
@ami-GS
Copy link
Contributor Author

ami-GS commented Apr 15, 2024

Oops, the failure blocks merging

@nibanks nibanks disabled auto-merge April 15, 2024 21:37
@nibanks nibanks merged commit a80ca97 into main Apr 15, 2024
178 of 315 checks passed
@nibanks nibanks deleted the dev/daiki/docker_multibuild branch April 15, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants