Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgconfig setting to link with pkg-config #4225

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Apr 4, 2024

Description

apt-get install pkg-config affects linking of libcrypto.so. arm build tries to link x86-64's libcrypto.so
This environment variable assists pkg-config to search right directory.

Testing

tested with commit da24f2d with this change.
Works fine.

Documentation

Is there any documentation impact for this change?

@ami-GS ami-GS requested a review from a team as a code owner April 4, 2024 19:46
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (e7b897d) to head (717ee33).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4225      +/-   ##
==========================================
- Coverage   84.15%   83.16%   -0.99%     
==========================================
  Files          56       56              
  Lines       15358    15358              
==========================================
- Hits        12924    12773     -151     
- Misses       2434     2585     +151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ami-GS ami-GS merged commit b8ca418 into main Apr 4, 2024
347 of 350 checks passed
@ami-GS ami-GS deleted the dev/daiki/cross_compile_fix_pkgconfig branch April 4, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants