-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard Tests for OpenSSL 3 #3388
Conversation
@wfurt it looks like Windows build fails?
|
Ok. I think I fixed it in my most recent commit. Builds locally now. |
Marking currently |
Hi @paulidale. We've started looking at OpenSSL 3.0 again, and it looks like HPS is pretty terrible with OpenSSL 3.0. Here's the data on Linux for instance. Linux HPS Perf v1.1.1
Linux HPS Perf v3.0
|
nice @nibanks. At lest we can now run them side by side. I assume the test does not depend on PGO? |
@wfurt yes, we can run them side by side now, and PGO isn't required. @paulidale it seems throughput also suffered (again, here's Linux data) v1.1.1
v3.0
|
Could you please try also openssl-3.1.0-beta1? |
I don't think there is a branch for that in quictls/openssl. |
I think the logic in |
I'm going to merge this to unblock testing and usage of openssl3 with MsQuic, but these issues need to be figured out. I'll open up a bug to track. |
What version of OpenSSL are you basing this from? (quictls/openssl)[https://github.com/quictls/openssl] might need an update? There have been a number of performance / bug fixes in the 3.0 series of releases & one in particular serialised libctx operations in a multiprocessor environment rather effectively. 3.1 has further improvements. |
Does 3.0.7 not have all the fixes? |
I think it's got the important ones. |
I think one of the important fixes that reduces the serialization is the libctx refactoring and that was merged only to 3.1 branch. |
Description
Adds tests for the recently onboarded OpenSSL 3 build support.
Testing
Automation
Documentation
N/A