Fix NULL Pointer Read in Stateless Retry Scenario (on Server) #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anrossi
reviewed
Aug 30, 2021
anrossi
approved these changes
Aug 30, 2021
nibanks
added a commit
that referenced
this pull request
Sep 20, 2021
Merged
nibanks
added a commit
that referenced
this pull request
Sep 20, 2021
Merged
nibanks
added a commit
that referenced
this pull request
Sep 21, 2021
nibanks
added a commit
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938 . Essentially, if the server takes too long to set the configuration on the connection, it's possible for MsQuic to clean up some state that it still needs later (and ends up reading a NULL pointer).
The test code was added first, to 100% reproduce the original issue. Next the core code that cleans up the state was moved to the handshake complete instead of on first usage. Verified new tests now passed.