Use root level certificate verification callback in OpenSSL #1818
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously using a callback that would be called after openssl did all of its verification internally. This resulted in multiple callbacks. Instead, we can just completely replace OpenSSL's verification. We then can decide to call openssl's verification directly or windows cert store verification depending on OS and sec config flags. This will always result in just a single callback to the app layer, but otherwise results in no actual behavior changes.
nibanks
approved these changes
Jul 14, 2021
anrossi
reviewed
Jul 14, 2021
anrossi
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using a callback that would be called after openssl did all of its verification internally. This resulted in multiple callbacks. Instead, we can just completely replace OpenSSL's verification. We then can decide to call openssl's verification directly or windows cert store verification depending on OS and sec config flags. This will always result in just a single callback to the app layer, but otherwise results in no actual behavior changes.
Closes #1810