-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 432 fix #989
Issue 432 fix #989
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #989 +/- ##
==========================================
- Coverage 78.66% 78.65% -0.02%
==========================================
Files 25 25
Lines 8133 8133
==========================================
- Hits 6398 6397 -1
- Misses 1735 1736 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Rather than is_connection_string
perhaps we should name it use_strict
or something like that for any reason why a stricter method should be used instead
So should we add use_strict to the other conversion functions as well (like convert_string_from_utf16)? |
Do you think it's necessary at this point? Or something we can revisit as needed? |
I say revisit as needed, no need to add it yet. |
Issue #432 fixed. |
No description provided.