Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 432 fix #989

Merged
merged 11 commits into from
May 13, 2019
Merged

Issue 432 fix #989

merged 11 commits into from
May 13, 2019

Conversation

david-puglielli
Copy link
Contributor

No description provided.

@david-puglielli david-puglielli requested a review from yitam May 10, 2019 00:19
@coveralls
Copy link

coveralls commented May 10, 2019

Coverage Status

Coverage increased (+0.1%) to 74.113% when pulling 60f20bd on david-puglielli:issue-432-fix into ffd9849 on microsoft:dev.

@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #989 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #989      +/-   ##
==========================================
- Coverage   78.66%   78.65%   -0.02%     
==========================================
  Files          25       25              
  Lines        8133     8133              
==========================================
- Hits         6398     6397       -1     
- Misses       1735     1736       +1
Impacted Files Coverage Δ
...php-7.1.29-src/ext/pdo_sqlsrv/shared/core_stmt.cpp 77.87% <0%> (-0.1%) ⬇️
...php-7.1.29-src/ext/pdo_sqlsrv/shared/core_util.cpp 43.91% <0%> (ø) ⬆️
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_util.cpp 46.52% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd9849...60f20bd. Read the comment docs.

Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Rather than is_connection_string perhaps we should name it use_strict or something like that for any reason why a stricter method should be used instead

@david-puglielli
Copy link
Contributor Author

So should we add use_strict to the other conversion functions as well (like convert_string_from_utf16)?

@yitam
Copy link
Contributor

yitam commented May 10, 2019

So should we add use_strict to the other conversion functions as well (like convert_string_from_utf16)?

Do you think it's necessary at this point? Or something we can revisit as needed?

@david-puglielli
Copy link
Contributor Author

I say revisit as needed, no need to add it yet.

@david-puglielli david-puglielli merged commit f369ce6 into microsoft:dev May 13, 2019
@david-puglielli
Copy link
Contributor Author

Issue #432 fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants