Added test case for Issue 699 #773
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #773 +/- ##
=======================================
Coverage 78.92% 78.92%
=======================================
Files 25 25
Lines 7213 7213
=======================================
Hits 5693 5693
Misses 1520 1520Continue to review full report at Codecov.
|
| --FILE-- | ||
| <?php | ||
|
|
||
| if (strtoupper(substr(PHP_OS, 0, 3)) === 'LIN') { |
There was a problem hiding this comment.
Is it better to put this in a skipif?
There was a problem hiding this comment.
no, because this is supposed to be temporary, I hope :)
There was a problem hiding this comment.
I changed this part to add a workaround to make the test pass in Linux
| while ($res = sqlsrv_next_result($stmt)); | ||
|
|
||
| if ($outParam != 123) { | ||
| echo "The output param value $outParam is unexpected!\n"; |
There was a problem hiding this comment.
I think display the $outParam here so we can see immediately what it is if it fails.
There was a problem hiding this comment.
yes, it is being printed in the echo stmt as $outParm
| // This test, when running outside of Windows, requires unixODBC 2.3.4 | ||
| // or above (see the list of bug fixes in www.unixodbc.org) | ||
| // Add this workaround for Linux platforms | ||
| $set_no_count = "SET NOCOUNT ON; "; |
There was a problem hiding this comment.
So this is the only thing that has to change to get the test to pass in Linux?
There was a problem hiding this comment.
yes, because unixODBC later versions fixed some bugs related to "SQLMoreResults" or "SQL_NO_DATA". By setting nocount these calls are bypassed.
Related to #699
This change is