Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest build scripts for building php 7.2 in appveyor #757

Merged
merged 12 commits into from
Apr 26, 2018
Merged

Use the latest build scripts for building php 7.2 in appveyor #757

merged 12 commits into from
Apr 26, 2018

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Apr 24, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Apr 24, 2018

Coverage Status

Coverage remained the same at 73.228% when pulling 246824a on yitam:php72 into 16e0b89 on Microsoft:dev.

@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #757 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #757   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files          25       25           
  Lines        7157     7157           
=======================================
  Hits         5644     5644           
  Misses       1513     1513
Impacted Files Coverage Δ
...-7.1.16-src/ext/pdo_sqlsrv/shared/core_results.cpp
...x86/php-7.1.16-src/ext/pdo_sqlsrv/php_pdo_sqlsrv.h
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_util.cpp
...cts/php/x86/php-7.1.16-src/ext/sqlsrv/php_sqlsrv.h
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_init.cpp
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_sqlsrv.h
...rojects/php/x86/php-7.1.16-src/ext/sqlsrv/util.cpp
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_stmt.cpp
.../php-7.1.16-src/ext/sqlsrv/shared/core_results.cpp
...php-7.1.16-src/ext/pdo_sqlsrv/shared/core_conn.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e0b89...246824a. Read the comment docs.

@yitam yitam requested a review from david-puglielli April 24, 2018 15:20
@yitam yitam merged commit f4436d0 into microsoft:dev Apr 26, 2018
@yitam yitam deleted the php72 branch August 13, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants