Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash caused by non-freed reference #589

Merged
merged 5 commits into from
Nov 8, 2017
Merged

Fixed crash caused by non-freed reference #589

merged 5 commits into from
Nov 8, 2017

Conversation

david-puglielli
Copy link
Contributor

@david-puglielli david-puglielli commented Nov 6, 2017

Fix for #434.


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.014% when pulling 10aa50c on david-puglielli:odbc32-crash-fix into 628e0c9 on Microsoft:dev.

@yukiwongky
Copy link
Contributor

You're not going to include a test for this PR? Perhaps the one that begins a transaction and execute an invalid query. Iterate 20 times.

@Hadis-Knj
Copy link

should have test for both PDO and SQLSRV to confirm it is fixed in PDO and doesn't exist in SQLSRV

@david-puglielli
Copy link
Contributor Author

Tests that crash because of the bug would still output the expected results/errors because the crash occurs after script execution has finished. Also, a test that crashes can still pass when run under run-tests.php, and there is no crash then. So a test that iterates beginTransaction() and query() 20 times could output whatever we want it to 20 times and then crash at the end, and run-tests.php won't catch it. We may need to use manual verification for this fix in future.

@codecov-io
Copy link

codecov-io commented Nov 7, 2017

Codecov Report

Merging #589 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #589      +/-   ##
==========================================
+ Coverage   74.84%   74.86%   +0.01%     
==========================================
  Files          50       50              
  Lines       14933    14933              
==========================================
+ Hits        11177    11179       +2     
+ Misses       3756     3754       -2
Impacted Files Coverage Δ
...x86/php-7.0.25-src/ext/pdo_sqlsrv/php_pdo_sqlsrv.h 65.38% <0%> (+3.84%) ⬆️
...x86/php-7.1.11-src/ext/pdo_sqlsrv/php_pdo_sqlsrv.h 100% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 628e0c9...4d627a0. Read the comment docs.

@yukiwongky
Copy link
Contributor

yukiwongky commented Nov 7, 2017

Should still include tests for "manual verification" in the future

@david-puglielli
Copy link
Contributor Author

Tests for manual verification that are always skipped when testing automatically on Github? I'll upload tests for that.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 73.037% when pulling 91418df on david-puglielli:odbc32-crash-fix into 628e0c9 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 73.037% when pulling e79f46b on david-puglielli:odbc32-crash-fix into 628e0c9 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 73.037% when pulling e2e82b2 on david-puglielli:odbc32-crash-fix into 628e0c9 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 73.037% when pulling 4d627a0 on david-puglielli:odbc32-crash-fix into 628e0c9 on Microsoft:dev.

@david-puglielli david-puglielli merged commit c983bca into microsoft:dev Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants