Refactor PDO tests with client buffer or table with all datatypes #582

yukiwongky · 2017-11-02T00:25:58Z

This change is

yukiwongky · 2017-11-02T00:27:56Z

test/functional/pdo_sqlsrv/pdo_testDataType.phpt

@@ -1,494 +0,0 @@
--TEST--
-Test the different type of data for retrieving


This test was deleted because it is a duplication of pdostatement_GetDataType.phpt

coveralls · 2017-11-02T00:38:03Z

Coverage increased (+0.09%) to 73.134% when pulling 1317d67 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

codecov-io · 2017-11-02T16:51:18Z

Codecov Report

Merging #582 into dev will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #582      +/-   ##
==========================================
+ Coverage   74.89%   74.96%   +0.07%     
==========================================
  Files          50       50              
  Lines       14915    14933      +18     
==========================================
+ Hits        11171    11195      +24     
+ Misses       3744     3738       -6

Impacted Files	Coverage Δ
...php/x86/php-7.1.11-src/ext/pdo_sqlsrv/pdo_stmt.cpp	`85.41% <0%> (-0.74%)`	⬇️
...php/x86/php-7.0.25-src/ext/pdo_sqlsrv/pdo_stmt.cpp	`84.63% <0%> (-0.72%)`	⬇️
...x86/php-7.1.11-src/ext/sqlsrv/shared/core_stmt.cpp	`80.67% <0%> (-0.07%)`	⬇️
...x86/php-7.0.25-src/ext/sqlsrv/shared/core_stmt.cpp	`78.8% <0%> (-0.07%)`	⬇️
...php/x86/php-7.1.11-src/ext/pdo_sqlsrv/pdo_util.cpp	`90.21% <0%> (ø)`	⬆️
...rojects/php/x86/php-7.0.25-src/ext/sqlsrv/util.cpp	`82.03% <0%> (ø)`	⬆️
...x86/php-7.0.25-src/ext/sqlsrv/shared/core_sqlsrv.h	`43.72% <0%> (ø)`	⬆️
...php-7.0.25-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h	`42.33% <0%> (ø)`	⬆️
...x86/php-7.1.11-src/ext/sqlsrv/shared/core_sqlsrv.h	`79.52% <0%> (ø)`	⬆️
...php/x86/php-7.0.25-src/ext/pdo_sqlsrv/pdo_util.cpp	`83.83% <0%> (ø)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd001a5...12f5e72. Read the comment docs.

coveralls · 2017-11-02T17:23:48Z

Coverage increased (+0.06%) to 73.104% when pulling a68abdb on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

coveralls · 2017-11-02T17:59:02Z

Coverage increased (+0.06%) to 73.104% when pulling 529c5aa on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

yitam

I just started reviewing, and I'll continue later.

yitam · 2017-11-02T21:30:18Z

test/functional/pdo_sqlsrv/MsData_PDO_AllTypes.inc

+        require_once("MsCommon_mid-refactor.inc");
+        if (isColEncrypted()) {
+            $xmlType = "nvarchar(max)";
+        } else {


We probably should keep the xml type with AE enabled

why? xml is not supported for encrypted columns.

yes, just thought we should test xml type even with AE enabled. There are hardly any other tests on XML type

how do I test it if it's not supported? no dot encrypt the column explicitly?

yes, just do not encrypt xml column or any other types that are not supported

yitam · 2017-11-02T21:31:55Z

test/functional/pdo_sqlsrv/MsData_PDO_AllTypes.inc

+$decimal_col = array(111.111, 222.222);
+
+$large_string = "This is a really large string used to test certain large data types like xml data type. The length of this string is greater than 256 to correctly test a large data type. This is currently used by atleast varchar type and by xml type. The fetch tests are the primary consumer of this string to validate that fetch on large types work fine. The length of this string as counted in terms of number of characters is 417.";
+


You mean at least?
Even 417 is not that big...

Now that I look at this the data is all simple chars... consider using more sophisticated data, at least with more extended ASCII characters?

This is the original data in MsData.inc. For this PR, I won't change it, but maybe we can add a task for testing with more sophisticated data on the PDO side.

Sure please. No doubt this is way too simple.

yitam · 2017-11-02T21:32:43Z

test/functional/pdo_sqlsrv/MsData_PDO_AllTypes.inc

+                               "FloatCol" => "float",
+                               "XmlCol" => $xmlType);
+        createTable($conn, $tbname, $columnMetaArr, "ON [PRIMARY]");
+    } catch (Exception $e) {


This test table is relatively small when compared to the test table in sqlsrv. Just saying ;)

:P too bad. This is the original table schema

yitam · 2017-11-02T21:36:36Z

test/functional/pdo_sqlsrv/MsData_PDO_AllTypes.inc

+                        "NVarCharCol" => $string_col[$rownum],
+                        "FloatCol" => $decimal_col[$rownum],
+                        "XmlCol" => $xml_col[$rownum]);
+        $stmt = insertRow($conn, $tbname, $inputs, "prepareBindParam");


why do quite a few columns use the same data?

again this is originally in MsData.inc

Why don't you overwrite MsData.inc? Why creating a new include file?

because we're in the middle of refactoring. Some not yet refactored tests may rely on the original MsData.inc

Are there many of them left not refactored? Perhaps refactor them all for this PR?

I'm not sure. All the tests that use the old connect() function from MsCommon.inc could use the data in MsData.inc. This PR is already large enough I don't think it's a wise decision to refactor any more tests.

yitam · 2017-11-02T21:38:43Z

test/functional/pdo_sqlsrv/MsData_PDO_AllTypes.inc

+            $textType = "text";
+            $xmlType = "xml";
+        }
+


Again, should probably keep the original data types even when AE is enabled?

but these datatypes are not supported for encrypted columns

Please see my reasons for xml types

yitam

I'm half way through now. Will continue soon.

yitam · 2017-11-03T17:36:57Z

test/functional/pdo_sqlsrv/PDO12_Info.phpt

        printf("Cannot find PDO driver line in phpinfo() output\n");
+    } else {


Perhaps rephrase the error message to refer to pdo_sqlsrv?

yitam · 2017-11-03T17:52:43Z

test/functional/pdo_sqlsrv/PDO24_ErrorCode.phpt

-    {
-        echo $e->getMessage();
+    if (($code != $expected) && (($expected != '00000') || ($code !=''))) {
+        printf("[%03d] Expecting error code '%s' got code '%s'\n", $offset, $expected, $code);


What's the chance of $code being an empty string? Perhaps check it using empty()?
Also, in this test, looks like $expected is always '00000'? What's the point of having it as an argument?
Looks like the if condition is never true...
Lastly, please consider getting rid of unnecessary parentheses

yitam · 2017-11-03T18:30:50Z

test/functional/pdo_sqlsrv/PDO25_ErrorInfo.phpt

            printf("[%03d] Driver-specific error code not set\n", $offset);
        }
-        if (!isset($info[2]) || ($info[2] == ''))
-        {
+        if (!isset($info[2]) || ($info[2] == '')) {
            printf("[%03d] Driver-specific error message.not set\n", $offset);
        }


Please remove the extra dot in the error message. Also, isset() probably suffices.

yitam · 2017-11-03T18:32:02Z

test/functional/pdo_sqlsrv/PDO25_ErrorInfo.phpt

+    @$conn1->query("SELECT id, label FROM [$table2]");
+    checkError(12, $conn1, '42S02');
+    checkError(13, $conn2, '42S02');
+    checkError(14, $stmt1);


In the original test, quite a few lines have been commented. Do you know why?

I actually don't know. Probably someone commented it out for debugging and just left it there.

yitam · 2017-11-03T18:32:40Z

test/functional/pdo_sqlsrv/PDO25_ErrorInfo.phpt

-    //CheckError(7, $stmt2, '42S02');
+    dropTable($conn1, $table1);
+    $stmt1->execute();
+    checkError(5, $conn1);


Where is the @ sign?

yitam · 2017-11-03T18:43:59Z

test/functional/pdo_sqlsrv/break_pdo.php

-        die ( print_r( sqlsrv_errors() ) );
+    $conn = new PDO("sqlsrv:server = $server ; Database = $dbName ;", $uid, $pwd);
+    if ($conn === false) {
+        die(print_r(sqlsrv_errors()));


Shouldn't exceptions be used instead of sqlsrv_errors()?

yitam · 2017-11-03T18:49:30Z

test/functional/pdo_sqlsrv/break_pdo.php

    }

    // Create table
    $sql = "CREATE TABLE $tableName1 ( c1 INT, c2 VARCHAR(40) )";
-    $stmt = $conn->query( $sql );
+    $stmt = $conn->query($sql);



please remove the extra spaces in the sql statements

yitam · 2017-11-03T18:56:26Z

test/functional/pdo_sqlsrv/pdo_connection_resiliency.phpt

-{
+try {
+    $conn = connect($connectionInfo, array(), PDO::ERRMODE_EXCEPTION, true);
+} catch (PDOException $e) {


perhaps explain why AE is disabled in this particular test?

yitam · 2017-11-03T19:33:54Z

test/functional/pdo_sqlsrv/pdo_error.phpt

    // query with a wrong column name.
-    $db->query( "Select * from " . $table1 . " where IntColX = 1"   );
-}
+    $db->query("Select * from " . $tbname . " where IntColX = 1");


Most tests use UPPER CASES for T-SQL keywords, so please change this as well.

yitam · 2017-11-03T19:44:19Z

test/functional/pdo_sqlsrv/pdo_insertDataType.phpt

+    unset($stmt);
+    unset($conn);
+    echo "Insert complete!\n";
+} catch (PDOException $e) {
    var_dump($e);
 }


So this test only inserts and nothing else?

yes, there is another test that inserts and selects

are they very similar? If so just remove one and marked it as duplicate?

yitam

Three tests are not shown as they were regarded as BINARY. Please double check why this happens. I'm done with the first round, finally

yitam · 2017-11-03T19:54:30Z

test/functional/pdo_sqlsrv/pdo_prepare.phpt

 --FILE--
 <?php
+require_once("MsCommon_mid-refactor.inc");
+require_once("MsData_PDO_AllTypes.inc");



Suggestion, include this MsData file in your MsCommon file instead. In case you need to change it later, you don't have to modify various tests that require this data file

I pulled this out explicitly so in the future we know which tests use table with all datatypes. If I need to change the name of the file later I'll just do replace all :)

yitam · 2017-11-03T19:55:19Z

test/functional/pdo_sqlsrv/pdo_prepare.phpt

-    if(!$stmt->execute())
-    {
+    $stmt = $db->prepare("select * from $tbname");
+    if (!$stmt->execute()) {
        die("Test_1 failed.");
    }


use exception for this entire test please

The whole test is wrapped by a try catch block. I think the test is OK now since it let us know which part of the test fails.

yitam · 2017-11-03T19:59:05Z

test/functional/pdo_sqlsrv/pdo_prepare_emulatePrepare_int.phpt


-$tableName = "fruit";
+    //$tableName = "fruit";
+    $tableName = getTableName();


Remove the commented line please

yitam · 2017-11-03T20:05:30Z

test/functional/pdo_sqlsrv/pdo_prepare_emulatePrepare_int.phpt

+        $options = array(PDO::ATTR_EMULATE_PREPARES => true);
+    }
+    $stmt = $conn->prepare($query, $options);
+    $stmt->bindParam(':cal', $cal, PDO::PARAM_INT);


With AE enabled, perhaps no need to run this second block? It's essentially the same as the one above, isn't it?

same as which one? pdo_prepare_emulatePrepare_float.phpt? This one is different, it binds int and uses PDO::PARAM_INT.

yitam · 2017-11-03T20:06:24Z

test/functional/pdo_sqlsrv/pdo_prepare_emulatePrepare_int.phpt

-$stmt = $conn->query($query);
+    if (!isColEncrypted()) {
+        // without emulate prepare, binding PARAM_INT with SQLSRV_ENCODING_SYSTEM is not allowed
+        // thus these are not tested when Column Encryption is disabled



I think you mean "the following will not be tested " when AE is enabled?
also, is not allowed or simply impossible, and not only with ENCODING_SYSTEM but the other two as well, I suppose? Please add a comment why.
There are several similar tests with emulate prepare, e.g. pdo_prepare_emulatePrepare_float.phpt
but you have refactored them differently. Please make them consistent.
regardless, shouldn't you handle such case with an error?

yitam · 2017-11-03T21:33:19Z

test/functional/pdo_sqlsrv/pdostatement_fetchColumn.phpt

+    $stmt = $db->query("Select * from $tbname");
+
+    // Fetch the first column from the next row in resultset. (This wud be first row since this is a first call to fetchcol)
+    $result = $stmt->fetchColumn();


Please use would, not wud :)

yitam · 2017-11-03T21:35:37Z

test/functional/pdo_sqlsrv/pdostatement_fetch_style.phpt

        print_r($err);
-    }   
+    }
 }



Please refactor this test some more as many methods are very similar

yitam · 2017-11-03T21:36:10Z

test/functional/pdo_sqlsrv/pdostatement_getColumnMeta.phpt

@@ -1,76 +1,81 @@
 --TEST--
 Test the PDOStatement::getColumnMeta() method (Note: there could be an issue about using a non-existent column index --- doesn't give any error/output/warning).
 --SKIPIF--
-<?php require('skipif.inc'); ?>
+<?php require('skipif_mid-refactor.inc'); ?>


Reduce the test and put more words into the description instead

yitam · 2017-11-03T21:38:02Z

test/functional/pdo_sqlsrv/pdostatement_getColumnMeta_unicode_col_name.phpt

@@ -1,124 +1,115 @@
 --TEST--
 Test the PDOStatement::getColumnMeta() method for Unicode column names (Note: there could be an issue about using a non-existent column index --- doesn't give any error/output/warning).
 --SKIPIF--


The test name is too long. Use description instead.

yitam · 2017-11-03T21:39:57Z

test/functional/pdo_sqlsrv/pdostatement_setFetchMode.phpt

-} 
-catch ( PDOException $e)
-{
+} catch (PDOException $e) {


Please refactor using loops and arrays to simplify the test

coveralls · 2017-11-03T21:45:38Z

Coverage increased (+0.06%) to 73.104% when pulling 0c74a27 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

coveralls · 2017-11-04T00:22:52Z

Coverage increased (+0.06%) to 73.105% when pulling e09dd91 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

coveralls · 2017-11-04T00:33:57Z

Coverage increased (+0.06%) to 73.105% when pulling e09dd91 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

coveralls · 2017-11-07T17:11:07Z

Coverage increased (+0.06%) to 73.105% when pulling 8ea405b on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

coveralls · 2017-11-07T19:54:52Z

Coverage increased (+0.06%) to 73.105% when pulling b695cc1 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

coveralls · 2017-11-07T20:17:19Z

Coverage increased (+0.06%) to 73.105% when pulling 3d2c54a on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

…rent columns

coveralls · 2017-11-07T21:17:33Z

Coverage increased (+0.06%) to 73.105% when pulling 7c02574 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

coveralls · 2017-11-08T00:11:17Z

Coverage increased (+0.06%) to 73.105% when pulling bedfd46 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

yitam

Didn't review pdostatement_GetDataType.phpt because it's regarded as BINARY

yitam · 2017-11-08T00:07:29Z

test/functional/pdo_sqlsrv/MsCommon_mid-refactor.inc

+    {
+        $unsupportedTypes = array("money", "smallmoney", "image", "ntext", "text", "xml", "sql_variant");
+        if (in_array(strtolower($this->dataType), $unsupportedTypes) && !$this->forceEncrypt) {
+            return false;


suggestion: test if forceEncrypt first?

yitam · 2017-11-08T00:15:01Z

test/functional/pdo_sqlsrv/pdo_ae_insert_pdoparam_money.phpt

-    foreach ( $dataTypes as $dataType ) {
+try {
+    $conn = connect('', array(), PDO::ERRMODE_SILENT);
+    foreach ($dataTypes as $dataType) {


Perhaps add a comment explaining why you set ERRMODE_SILENT
because not all the AE specific tests have this error mode

The comment sounds unclear. Please rephrase when you have a chance.

yitam · 2017-11-08T00:15:27Z

test/functional/pdo_sqlsrv/pdo_ae_insert_pdoparam_money.phpt

            echo "Test successfully done.\n";
-        DropTable( $conn, $tbname );
+        }
+        DropTable($conn, $tbname);
    }


dropTable()

yitam · 2017-11-08T00:17:45Z

test/functional/pdo_sqlsrv/pdo_ae_insert_retrieve.phpt

+                         new columnMeta("nvarchar(50)", "LastName", "NULL"),
+                         new columnMeta("date", "BirthDate", null, "randomized"));
+    createTable($conn, $tbname, $colMetaArr);
+


ColumnMeta

yitam · 2017-11-08T00:19:30Z

test/functional/pdo_sqlsrv/pdo_ae_insert_retrieve_nvarchar.phpt

+        $conn1 = connect('', array(), PDO::ERRMODE_EXCEPTION, true);
+        $stmt = $conn1->query($selectSql);
+        while ($decrypted_row = $stmt->fetch(PDO::FETCH_ASSOC)) {
+            if ($decrypted_row[ 'CharCount' ] == strlen($decrypted_row[getDefaultColName("nvarchar(1000)")])) {
                $rowInd = $decrypted_row[ 'CharCount' ] + 1;
                echo "Failed to encrypted at row $rowInd\n";


please remove spaces within square brackets

yitam · 2017-11-08T00:20:25Z

test/functional/pdo_sqlsrv/pdo_ae_insert_string.phpt

+        $tbname = getTableName();
+        $colMetaArr = array( new columnMeta($dataType, "c_det"), new columnMeta($dataType, "c_rand", null, "randomized"));
+        createTable($conn, $tbname, $colMetaArr);
+


ColumnMeta

yukiwongky · 2017-11-08T01:06:59Z

@yitam , these ae tests were never tested on SQL Server 2K12 before, and seems to be more strict on decimal types. As for pdo_ae_insert_pdoparam_numeric.phpt, the initial expected values were wrong.

coveralls · 2017-11-08T01:26:26Z

Coverage increased (+0.06%) to 73.105% when pulling 12f5e72 on v-kaywon:refactorPDOTests3 into bd001a5 on Microsoft:dev.

yitam

Just a couple more suggestions.

yitam · 2017-11-08T16:19:42Z

test/functional/pdo_sqlsrv/pdo_ae_insert_pdoparam_money.phpt

-    foreach ( $dataTypes as $dataType ) {
+try {
+    $conn = connect('', array(), PDO::ERRMODE_SILENT);
+    foreach ($dataTypes as $dataType) {


The comment sounds unclear. Please rephrase when you have a chance.

yitam · 2017-11-08T16:33:08Z

test/functional/pdo_sqlsrv/MsCommon.inc

-     exit;
-  }
-}
-
 function teardown()
 {
    // TBD


There are quite a few methods in MsCommon.inc that are probably not very useful. Next time please consider merging your changes in mid-refactor to this one and removing the unused helper methods.

yukiwongky added 2 commits November 1, 2017 17:09

refactor PDO tests with client buffer or table with all datatypes

50d3c19

remove xfail from pdostatement_nextRowset.phpt

1317d67

yukiwongky commented Nov 2, 2017

View reviewed changes

change include file to MsCommon_mid-refactor.inc in pdo_quote.phpt

a68abdb

fix typo in pdo_utf8_conn.phpt

529c5aa

yukiwongky requested a review from yitam November 2, 2017 18:02

yitam reviewed Nov 2, 2017

View reviewed changes

yitam reviewed Nov 3, 2017

View reviewed changes

address review comments

0c74a27

yitam reviewed Nov 3, 2017

View reviewed changes

yukiwongky added 2 commits November 3, 2017 17:01

address review comments

a60992f

add exception handling for pdo_transaction.phpt

e09dd91

yukiwongky added 2 commits November 6, 2017 17:30

add refactored ae related tests

1e69c86

update AEData.inc and MsCommon_mid-refactor.inc for the ae related tests

8ea405b

yukiwongky added 2 commits November 7, 2017 10:01

change to default API used for inserting row in pdo_ae_output_param.phpt

ce23b38

test column encryption unsupported types

b695cc1

yukiwongky added 2 commits November 7, 2017 12:04

remove odl MsData.inc

708a29c

test column encryption unsupported types in MsData_PDO_AllTypes.inc

3d2c54a

refactor pdostatement_GetDataType.phpt to use common method for diffe…

7c02574

…rent columns

fix decimal related tests to work on SQL Server 2k12

bedfd46

yitam reviewed Nov 8, 2017

View reviewed changes

apply review commnets

12f5e72

yitam approved these changes Nov 8, 2017

View reviewed changes

yukiwongky merged commit 07ac237 into microsoft:dev Nov 8, 2017

yukiwongky deleted the refactorPDOTests3 branch January 15, 2018 20:44

		@@ -1,494 +0,0 @@
		--TEST--
		Test the different type of data for retrieving

		$decimal_col = array(111.111, 222.222);

		$large_string = "This is a really large string used to test certain large data types like xml data type. The length of this string is greater than 256 to correctly test a large data type. This is currently used by atleast varchar type and by xml type. The fetch tests are the primary consumer of this string to validate that fetch on large types work fine. The length of this string as counted in terms of number of characters is 417.";

		printf("Cannot find PDO driver line in phpinfo() output\n");
		} else {

Refactor PDO tests with client buffer or table with all datatypes #582

Refactor PDO tests with client buffer or table with all datatypes #582

Conversation

yukiwongky commented Nov 2, 2017 • edited by lilgreenbird Loading

Choose a reason for hiding this comment

coveralls commented Nov 2, 2017

codecov-io commented Nov 2, 2017 • edited Loading

Codecov Report

coveralls commented Nov 2, 2017

coveralls commented Nov 2, 2017

yitam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yitam Nov 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yitam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yitam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 3, 2017

coveralls commented Nov 4, 2017

coveralls commented Nov 4, 2017

coveralls commented Nov 7, 2017

coveralls commented Nov 7, 2017

coveralls commented Nov 7, 2017

coveralls commented Nov 7, 2017

coveralls commented Nov 8, 2017

yitam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yukiwongky commented Nov 2, 2017 •

edited by lilgreenbird

Loading

codecov-io commented Nov 2, 2017 •

edited

Loading

yitam Nov 3, 2017 •

edited

Loading