fix crash from getting the numrow of a null buffered result set #333

yukiwongky · 2017-03-20T23:03:30Z

fit for #330
fix crash from sqlsrv_num_rows to get the numrow in a client buffered result set that is null
added test

…test

coveralls · 2017-03-20T23:09:01Z

Coverage increased (+0.02%) to 55.396% when pulling c1a1a06 on v-kaywon:numrow_null_result into 7434d06 on Microsoft:dev.

Hadis-Knj · 2017-03-23T17:49:27Z

source/shared/core_results.cpp

+		return zend_hash_num_elements( cache );
+	}
+	else {
+		return -1;


Please add a comment that what does -1 mean

coveralls · 2017-03-23T17:57:26Z

Coverage increased (+0.02%) to 55.396% when pulling d68300f on v-kaywon:numrow_null_result into 7434d06 on Microsoft:dev.

fix crash from getting the numrow of a null buffered result set; add …

c1a1a06

…test

yukiwongky requested a review from Hadis-Knj March 20, 2017 23:45

Hadis-Knj reviewed Mar 23, 2017

View reviewed changes

Hadis-Knj approved these changes Mar 23, 2017

View reviewed changes

Update core_results.cpp

d68300f

yukiwongky merged commit 566a2da into microsoft:dev Mar 23, 2017

yukiwongky deleted the numrow_null_result branch June 30, 2017 21:15

Provide feedback