issue #270 fix #297
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| --TEST-- | ||
| Test fetch from binary, varbinary, varbinary(max), image columns, without setting binary encoding. | ||
| --DESCRIPTION-- | ||
| Verifies GitHub issue 270 is fixed, users could not retrieve the data as inserted in binary columns without setting the binary encoding either on stmt or using bindCoulmn encoding. | ||
| This test verifies that the data inserted in binary columns can be retrieved using fetch, fetchColumn, fetchObject, and fetchAll functions. | ||
|
|
||
| --FILE-- | ||
| <?php | ||
|
|
||
| require_once("autonomous_setup.php"); | ||
|
|
||
| $tableName = 'test_binary'.rand(); | ||
| $columns = array( 'col1', 'col2', 'col3', 'col4'); | ||
|
|
||
| // Connect | ||
| $conn = new PDO( "sqlsrv:server=$serverName;Database=tempdb", $username, $password ); | ||
|
|
||
| $sql = "CREATE TABLE $tableName ( $columns[0] binary(50), $columns[1] VARBINARY(50), $columns[2] VARBINARY(MAX), $columns[3] image)"; | ||
| $conn->exec($sql); | ||
|
|
||
| $icon = base64_decode("This is some text to test retrieving from binary type columns"); | ||
|
|
||
| // Insert data using bind parameters | ||
| $sql = "INSERT INTO $tableName($columns[0], $columns[1], $columns[2], $columns[3]) VALUES(?, ?, ?, ?)"; | ||
| $stmt = $conn->prepare($sql); | ||
| $stmt->bindParam(1, $icon, PDO::PARAM_LOB, null, PDO::SQLSRV_ENCODING_BINARY); | ||
| $stmt->bindParam(2, $icon, PDO::PARAM_LOB, null, PDO::SQLSRV_ENCODING_BINARY); | ||
| $stmt->bindParam(3, $icon, PDO::PARAM_LOB, null, PDO::SQLSRV_ENCODING_BINARY); | ||
| $stmt->bindParam(4, $icon, PDO::PARAM_LOB, null, PDO::SQLSRV_ENCODING_BINARY); | ||
| $stmt->execute(); | ||
|
|
||
| // loop through each column in the table | ||
| foreach ($columns as $col){ | ||
| test_fetch($conn, $tableName, $col, $icon); | ||
| } | ||
| // DROP table | ||
| $conn->query("DROP TABLE $tableName") ?: die(); | ||
|
|
||
| //free statement and connection | ||
| $stmt = null; | ||
| $conn = null; | ||
|
|
||
| print_r("Test finished successfully"); | ||
|
|
||
| //calls various fetch methods | ||
| function test_fetch($conn, $tableName, $columnName, $input){ | ||
|
|
||
| $len = strlen($input); | ||
| $result = ""; | ||
| $sql = "SELECT $columnName from $tableName"; | ||
|
|
||
| $stmt = $conn->query($sql); | ||
| $stmt->bindColumn(1, $result, PDO::PARAM_LOB); | ||
| $stmt->fetch(PDO::FETCH_BOUND); | ||
| //binary is fixed size, to evaluate output, compare it using strncmp | ||
| if( strncmp($result, $input, $len) !== 0){ | ||
| print_r("\nRetrieving using bindColumn failed"); | ||
| } | ||
|
There was a problem hiding this comment. Perhaps testing equality like ($result === $input) is enough? There was a problem hiding this comment. binary column is fixed size (50), and input len is 36, so we don't care about the white spaces appended to the output and only compare the first 36 characters, this is just testing that value is not hex number anymore |
||
|
|
||
| $result = ""; | ||
| $stmt = $conn->query($sql); | ||
| $stmt->bindColumn(1, $result, PDO::PARAM_LOB, 0 , PDO::SQLSRV_ENCODING_BINARY); | ||
| $stmt->fetch(PDO::FETCH_BOUND); | ||
| if( strncmp($result, $input, $len) !== 0){ | ||
| print_r("\nRetrieving using bindColumn with encoding set failed"); | ||
| } | ||
|
|
||
| $result = ""; | ||
| $stmt = $conn->query($sql); | ||
| $result = $stmt->fetchColumn(); | ||
| if( strncmp($result, $input, $len) !== 0){ | ||
| print_r("\nRetrieving using fetchColumn failed"); | ||
| } | ||
|
|
||
| $result = ""; | ||
| $stmt = $conn->query($sql); | ||
| $result = $stmt->fetchObject(); | ||
| if( strncmp($result->$columnName, $input, $len) !== 0){ | ||
| print_r("\nRetrieving using fetchObject failed"); | ||
| } | ||
|
|
||
| $result = ""; | ||
| $stmt = $conn->query($sql); | ||
| $result = $stmt->fetchAll( PDO::FETCH_COLUMN ); | ||
| if( strncmp($result[0], $input, $len) !== 0){ | ||
| print_r("\nRetrieving using fetchAll failed"); | ||
| } | ||
| } | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| Test finished successfully | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change mean that each field can have its own encoding set via bindColumn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it sets the encoding to stmt or conn encoding and in case of binary or invalid it is set to binary or invalid encoding respectively.