Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang compile errors. #289

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Fix clang compile errors. #289

merged 1 commit into from
Feb 15, 2017

Conversation

v-dareck
Copy link
Contributor

Change char* to const char* and add locale include.

@v-dareck v-dareck requested review from Hadis-Knj and yitam February 15, 2017 01:18
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.473% when pulling c35d998 on v-dareck:clang_errors into c6157b0 on Microsoft:dev.

yitam
yitam approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad you now use const instead of static_cast here and there

@yitam yitam merged commit f2df031 into microsoft:dev Feb 15, 2017
@v-dareck v-dareck deleted the clang_errors branch February 24, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yitam yitam yitam approved these changes

@Hadis-Knj Hadis-Knj Awaiting requested review from Hadis-Knj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-dareck @coveralls @yitam