Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning compiling core_stmt.cpp #1275

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Jul 1, 2021

Let's fix this compilation warning:

source/sqlsrv/shared/core_stmt.cpp:3104:25: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
         buffer_length = NULL;
                         ^~~~

converting to non-pointer type 'long int' from NULL
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1275 (8ab61eb) into PHP-8.1-dev (f00dc9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           PHP-8.1-dev    #1275   +/-   ##
============================================
  Coverage        83.27%   83.27%           
============================================
  Files               22       22           
  Lines             7780     7780           
============================================
  Hits              6479     6479           
  Misses            1301     1301           

@yitam
Copy link
Contributor

yitam commented Jul 5, 2021

Thanks @mlocati for the contribution.

@yitam yitam merged commit bde9812 into microsoft:PHP-8.1-dev Jul 5, 2021
@mlocati mlocati deleted the core_stmt-buffer_length branch July 5, 2021 16:33
@mlocati
Copy link
Contributor Author

mlocati commented Jul 5, 2021

That was an easy one 😉

yitam pushed a commit that referenced this pull request Jul 5, 2021
converting to non-pointer type 'long int' from NULL
yitam added a commit that referenced this pull request Jul 5, 2021
converting to non-pointer type 'long int' from NULL

Co-authored-by: Michele Locati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants