-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set logger for driver API #1107
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1107 +/- ##
==========================================
- Coverage 76.92% 76.72% -0.20%
==========================================
Files 25 25
Lines 7424 7417 -7
==========================================
- Hits 5711 5691 -20
- Misses 1713 1726 +13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just noticed a few minor things.
@@ -0,0 +1,56 @@ | |||
--TEST-- | |||
Tset functions return FALSE for errors with logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tset functions return FALSE for errors with logging | |
Test functions return FALSE for errors with logging |
@@ -0,0 +1,49 @@ | |||
--TEST-- | |||
Tset functions return FALSE for errors with logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tset functions return FALSE for errors with logging | |
Test functions return FALSE for errors with logging |
source/sqlsrv/conn.cpp
Outdated
|
||
// get the structure | ||
ss_sqlsrv_conn *conn = static_cast<ss_sqlsrv_conn*>( rsrc->ptr ); | ||
SQLSRV_ASSERT( conn != NULL, "sqlsrv_conn_dtor: connection was null"); | ||
|
||
SET_FUNCTION_NAME( *conn ); | ||
conn->set_func("sqlsrv_conn_dtor"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would _FN_ work here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not this one because the macro LOG_FUNCTION is commented but I can certainly use __func__
Thanks :)
No description provided.