Skip to content

Commit

Permalink
Applied review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
yitam committed Feb 10, 2020
1 parent 7510c8d commit e26c31d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions test/functional/pdo_sqlsrv/pdo_ae_insert_numeric.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ c_rand: 922337203685479936

Testing decimal\(18,5\):
-----Encrypted default type is compatible with encrypted decimal\(18,5\)-----
c_det: -9223372036854.80000
c_rand: 9223372036854.80000
c_det: -9223372036854\.80000
c_rand: 9223372036854\.80000

Testing numeric\(10,5\):
-----Encrypted default type is compatible with encrypted numeric\(10,5\)-----
Expand Down
8 changes: 4 additions & 4 deletions test/functional/pdo_sqlsrv/pdo_test_non_LOB_types.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ Array
\[3\] => 255
\[4\] => 1
\[5\] => 9999999999999999999999999999999999999
\[6\] => 922337203685477.5807
\[7\] => 214748.3647
\[8\] => 1.79E\+308
\[9\] => (1.18E-38|1.1799999E-38)
\[6\] => 922337203685477\.5807
\[7\] => 214748\.3647
\[8\] => 1\.79E\+308
\[9\] => (1\.18E-38|1\.1799999E-38)
\[10\] => 1968-12-12 16:20:00.000
\[11\] =>
\)
4 changes: 2 additions & 2 deletions test/functional/sqlsrv/srv_007_login_timeout.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $timeout = 20;
$maxAttempts = 3;
$numAttempts = 0;

// The difference in time elapsed is platform dependent, and in some distros, such as Alpine or Suse, extra delay may be caused by the attempts to resolve non-existant hostnames
// The difference in time elapsed is platform dependent, and in some distros, such as Alpine or Suse, extra delay may be caused by the attempts to resolve non-existent hostnames
// Set leeway to 2 seconds to allow some room of such errors
$leeway = 2.0;
$missed = false;
Expand All @@ -41,7 +41,7 @@ do {
echo "Connection failed at $elapsed secs. Leeway is $leeway sec but the difference is $diff\n";
} else {
// The test will fail but this helps us decide if this test should be redesigned
echo "$numAttempts: $diff\n";
echo "Attempts: $numAttempts, Time difference: $diff\n";
sleep(5);
}
}
Expand Down

0 comments on commit e26c31d

Please sign in to comment.