Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NCCL APIs #319

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Support NCCL APIs #319

merged 5 commits into from
Jun 27, 2024

Conversation

caiomcbr
Copy link
Contributor

@caiomcbr caiomcbr commented Jun 24, 2024 •
edited by chhwang
Loading

Start supporting NCCL APIs with a few limitations.

@caiomcbr caiomcbr assigned caiomcbr and chhwang and unassigned caiomcbr Jun 24, 2024
@caiomcbr caiomcbr requested a review from chhwang June 24, 2024 23:53
chhwang
chhwang approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will clean up the kernels in another PR.

@chhwang chhwang changed the title NCCL API Integration Support NCCL APIs Jun 27, 2024
@chhwang chhwang enabled auto-merge (squash) June 27, 2024 23:09
@chhwang chhwang merged commit b1b9d06 into main Jun 27, 2024
17 checks passed
@chhwang chhwang deleted the caiorocha/ncclapi_integration branch June 27, 2024 23:54
@Binyang2014 Binyang2014 mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhwang chhwang chhwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caiomcbr @chhwang