Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C++ executor test #304

Merged
merged 25 commits into from
May 29, 2024
Merged

Add C++ executor test #304

merged 25 commits into from
May 29, 2024

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented May 20, 2024 •
edited by Binyang2014
Loading

  • Add C++ executor test
  • Fix executor bugs for packet operation
  • Enhance executor_test.py

@Binyang2014 Binyang2014 marked this pull request as ready for review May 29, 2024 03:40
@Binyang2014 Binyang2014 requested a review from yzygitzh May 29, 2024 03:41
chhwang
chhwang commented May 29, 2024
View reviewed changes
Copy link
Contributor Author

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve as I opened this PR

test/executor_test.cc Outdated Show resolved Hide resolved
src/nvls.cc Show resolved Hide resolved
src/executor/execution_plan.cc Outdated Show resolved Hide resolved
@Binyang2014 Binyang2014 enabled auto-merge (squash) May 29, 2024 07:18
@Binyang2014 Binyang2014 merged commit 1f62dfd into main May 29, 2024
15 checks passed
@Binyang2014 Binyang2014 deleted the binyli/executor_opt branch May 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Binyang2014 Binyang2014 Binyang2014 left review comments

@yzygitzh yzygitzh yzygitzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chhwang @Binyang2014 @yzygitzh