Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mscclpp-test in Python #204

Merged
merged 68 commits into from
Nov 16, 2023
Merged

mscclpp-test in Python #204

merged 68 commits into from
Nov 16, 2023

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Oct 26, 2023

No description provided.

root and others added 28 commits October 16, 2023 06:16
@chhwang chhwang linked an issue Oct 26, 2023 that may be closed by this pull request
[Feature] Improving code from mscclpp-test and examples #207
Closed
@saeedmaleki saeedmaleki marked this pull request as ready for review November 13, 2023 02:09
@Binyang2014 Binyang2014 linked an issue Nov 13, 2023 that may be closed by this pull request
[Perf] Two-node allreduce perf improvement #210
Closed
chhwang
chhwang commented Nov 14, 2023
View reviewed changes
Copy link
Contributor Author

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve as I'm an author

include/mscclpp/concurrency.hpp Show resolved Hide resolved
include/mscclpp/sm_channel_device.hpp Show resolved Hide resolved
python/benchmark/allreduce.cu Show resolved Hide resolved
@chhwang chhwang changed the title Saemal/py mscclpp mscclpp-test in Python Nov 14, 2023
Binyang2014
Binyang2014 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

python/mscclpp/utils.py Show resolved Hide resolved
@chhwang chhwang merged commit 060fda1 into main Nov 16, 2023
15 checks passed
@chhwang chhwang deleted the saemal/py_mscclpp branch November 16, 2023 04:45
@chhwang chhwang mentioned this pull request Nov 24, 2023
Closed
@chhwang chhwang linked an issue Nov 24, 2023 that may be closed by this pull request
[Feature] Support python-based mscclpp-test #187
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeedmaleki saeedmaleki saeedmaleki approved these changes

@Binyang2014 Binyang2014 Binyang2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@chhwang @Binyang2014 @saeedmaleki @eschouks