Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [0.36.0] dependencies accidently installed? #3601

Closed
2 tasks done
AviVahl opened this issue Feb 26, 2023 · 2 comments · Fixed by #3606 or #3607
Closed
2 tasks done

[Bug] [0.36.0] dependencies accidently installed? #3601

AviVahl opened this issue Feb 26, 2023 · 2 comments · Fixed by #3606 or #3607
Assignees
Labels
Milestone

Comments

@AviVahl
Copy link

AviVahl commented Feb 26, 2023

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Reproduction Steps

npm i monaco-editor

Actual (Problematic) Behavior

Since this commit: 10577a0#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

3 dependencies are now installed for monaco-editor consumers:

{
	"dependencies": {
		"@types/shelljs": "^0.8.11",
		"pin-github-action": "^1.8.0",
		"shelljs": "^0.8.5"
	}
}

Expected Behavior

I'm guessing these should be devDeps

Additional Context

No response

@artola
Copy link

artola commented Feb 26, 2023

Yes, I got the same. This PR introduced all these as dependencies when they should be declared as devDependencies:

10577a0

@hediet is it right? I got around 20 new dependencies installed.
@alexdima Are you planning a new release with a fix?

@hediet hediet added this to the February 2023 milestone Feb 27, 2023
@hediet hediet added the debt label Feb 27, 2023
@hediet hediet self-assigned this Feb 27, 2023
@hediet
Copy link
Member

hediet commented Feb 27, 2023

Thanks for point this out!
I accidentally added these dependencies as normal dependency, though they should have been dev dependencies.

@hediet hediet mentioned this issue Feb 27, 2023
hediet added a commit that referenced this issue Feb 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants