We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No response
npm i monaco-editor
Since this commit: 10577a0#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
3 dependencies are now installed for monaco-editor consumers:
{ "dependencies": { "@types/shelljs": "^0.8.11", "pin-github-action": "^1.8.0", "shelljs": "^0.8.5" } }
I'm guessing these should be devDeps
The text was updated successfully, but these errors were encountered:
Yes, I got the same. This PR introduced all these as dependencies when they should be declared as devDependencies:
dependencies
devDependencies
10577a0
@hediet is it right? I got around 20 new dependencies installed. @alexdima Are you planning a new release with a fix?
Sorry, something went wrong.
Thanks for point this out! I accidentally added these dependencies as normal dependency, though they should have been dev dependencies.
Fixes #3601
1d29a64
Merge pull request #3606 from microsoft/hediet/smart-puma
30e5599
hediet
Successfully merging a pull request may close this issue.
Reproducible in vscode.dev or in VS Code Desktop?
Reproducible in the monaco editor playground?
Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response
Reproduction Steps
npm i monaco-editor
Actual (Problematic) Behavior
Since this commit: 10577a0#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
3 dependencies are now installed for monaco-editor consumers:
Expected Behavior
I'm guessing these should be devDeps
Additional Context
No response
The text was updated successfully, but these errors were encountered: