Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normally ignored errors caused by animated icon #5236

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

StephenLPeters
Copy link
Contributor

Many usages of animated icon set the state property with setters that did not specify the appropriate namespace which leads to errors which are by default ignored.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 21, 2021
@StephenLPeters
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-AnimatedIcon team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 21, 2021
Copy link
Contributor

@ranjeshj ranjeshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters StephenLPeters merged commit 4d9d005 into main Jun 22, 2021
@StephenLPeters StephenLPeters deleted the user/stpete/AnimatedIconFailFast branch June 22, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-AnimatedIcon team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants