Updating CommandBarFlyout keyboarding and UIA to account for AlwaysExpanded hiding the more button #5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y account for the fact that the more button can be absent.
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
teaP
reviewed
Jun 3, 2021
… potentially changes.
…andBarFlyoutKeyboarding
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
area-Commanding
ranjeshj
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AlwaysExpandedAPI hides the more button, but there are some aspects of keyboarding and UIA that assume that the more button will always be visible. These changes update keyboarding and UIA to account for the possible absence of the more button. While I was here, I also refactored keyboard handling to make it more understandable - now there aren't any special cases for the more button; instead, we just make two lists of controls accessible via the horizontal arrow keys and the vertical arrow keys, and then cycle through those lists in response to keyboard input.I also added more test cases to confirm that both keyboarding and UIA functions as expected with
AlwaysExpandedset to true.