Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NavigationView]: Fix bug where footer scrollbar would still show up on v1 style #5073

Merged
merged 1 commit into from
May 25, 2021
Merged

[NavigationView]: Fix bug where footer scrollbar would still show up on v1 style #5073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dev/NavigationView/NavigationView_v1.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,10 @@
<!-- "Non header" content -->
<Grid x:Name="ItemsContainerGrid" Grid.Row="6" Margin="0,0,0,8">
<Grid.RowDefinitions>
<RowDefinition x:Name="MenuItemsRow" Height="Auto" MinHeight="{ThemeResource NavigationViewItemOnLeftMinHeight}"/> <!-- MenuItems -->
<RowDefinition Height="*" MinHeight="21"/> <!-- Fill spacing -->
<RowDefinition Height="*"/> <!-- MenuItems -->
<RowDefinition Height="Auto"/> <!-- Fill spacing -->
<RowDefinition Height="Auto" /> <!-- PaneFooter -->
<RowDefinition x:Name="FooterItemsRow" Height="Auto" MinHeight="{ThemeResource NavigationViewItemOnLeftMinHeight}"/> <!-- FooterItems -->
<RowDefinition Height="Auto"/> <!-- FooterItems -->
</Grid.RowDefinitions>

<!-- MenuItems -->
Expand Down Expand Up @@ -493,6 +493,7 @@
<!-- FooterItems -->
<local:ItemsRepeaterScrollHost Grid.Row="3">
<ScrollViewer x:Name="FooterItemsScrollViewer"
VerticalScrollBarVisibility="Auto"
beervoley marked this conversation as resolved.
Show resolved Hide resolved
contract7Present:VerticalAnchorRatio="1">
<local:ItemsRepeater
x:Name="FooterMenuItemsHost"
Expand Down