Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing SplitButton's handling on keyboard input #5064

Merged
merged 1 commit into from
May 21, 2021
Merged

Fixing SplitButton's handling on keyboard input #5064

merged 1 commit into from
May 21, 2021

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented May 21, 2021

The SplitButton did not trigger its Command with keyboard input. It now does the same processing as the OS Xaml ButtonBase.
Updated the interactive test accordingly.

@RBrid RBrid self-assigned this May 21, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label May 21, 2021
@RBrid
Copy link
Contributor Author

RBrid commented May 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

teaP
teaP approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@teaP teaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh that explains it. Clicking on the primary button executes the command because the command is attached to that button, but WE handle keyboard input so it wasn't happening on space/enter. Thanks for figuring it out!!

@RBrid
Copy link
Contributor Author

RBrid commented May 21, 2021

Yes indeed teaP, you got it.

@RBrid RBrid merged commit 4fc34de into main May 21, 2021
@RBrid RBrid deleted the user/regisb/SplitButtonFix4 branch May 21, 2021 02:13
@StephenLPeters StephenLPeters added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teaP teaP teaP approved these changes

@StephenLPeters StephenLPeters Awaiting requested review from StephenLPeters

@karkarl karkarl Awaiting requested review from karkarl

@ranjeshj ranjeshj Awaiting requested review from ranjeshj

Assignees

@RBrid RBrid

Labels
area-SplitButton team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RBrid @teaP @StephenLPeters