Add a MirroredWhenRightToLeft API to AnimatedIcon #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
reviewed
May 17, 2021
ranjeshj
reviewed
May 17, 2021
| @@ -22,13 +22,17 @@ unsealed runtimeclass AnimatedIcon : Windows.UI.Xaml.Controls.IconElement | |||
| [MUX_PROPERTY_CHANGED_CALLBACK(TRUE)] | |||
| IconSource FallbackIconSource{ get; set; }; | |||
|
|
|||
| [MUX_PROPERTY_CHANGED_CALLBACK(TRUE)] | |||
| Boolean MirroredWhenRightToLeft{ get; set; }; | |||
There was a problem hiding this comment.
Do we need to update any of our usages to set this property to non default ?
There was a problem hiding this comment.
Some Icons have specific Right to Left versions which are not just mirrors. Is there a good way to swap out the Animated Icon and Fallback, for those cases?
jevansaks
previously requested changes
May 17, 2021
… NavigationViewBackButton to mirror.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
May 20, 2021
beervoley
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some animated icons should be mirrored when the flow direction is RTL, like the BackButton. Some should not, like the checkmark. This PR adds an API to animated icon that allows opting into mirroring on a per animated icon basis. The default is to not mirror, which is a change in behavior.