MediaTransportControls Visual Update #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
reviewed
May 13, 2021
beervoley
reviewed
May 13, 2021
beervoley
added
area-MediaPlayerElement
area-MediaElement
area-UIDesign
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -756,35 +284,61 @@ | |||
| <RowDefinition /> | |||
| <RowDefinition Height="Auto" /> | |||
| </Grid.RowDefinitions> | |||
| <Slider x:Name="ProgressSlider" Style="{StaticResource MediaSliderStyle}" Margin="12,0" MinWidth="80" Height="33" VerticalAlignment="Center" IsThumbToolTipEnabled="False" /> | |||
| <Slider x:Name="ProgressSlider" | |||
| Margin ="7,2,7,1" | |||
There was a problem hiding this comment.
should these values be resources?
beervoley
reviewed
May 14, 2021
beervoley
approved these changes
May 14, 2021
StephenLPeters
removed
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Known issues: shadows and commandBar margins requiring codebehind changes in the OS