ItemsRepeater: Avoid layout cycle exception with variable sized children in StackLayout #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
reviewed
May 17, 2021
ranjeshj
reviewed
May 17, 2021
ranjeshj
approved these changes
May 17, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Putting in a guard against the XAML framework's layout cycle exception.
Motivation and Context
When a virtualized StackLayout has variable sized children, the estimated extent for the ItemsRepeater may not settle down during a layout pass.
This results in an app crash with the E_LAYOUTCYCLE error. We shortcut the cycle by returning the previous desired size in ItemsRepeater::MeasureOverride and escape the exception.
How Has This Been Tested?
Ad-hoc testing with repro apps.
A regression test is being added too.