Fixing UniformGridLayout items-per-line evaluation #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
team-Controls
ranjeshj
approved these changes
May 11, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The UniformGridLayout class was incorrectly evaluating the number of displayed items per line. This caused occasional jumps when scrolling an ItemsRepeater in a ScrollViewer.
Motivation and Context
Another side effect of this bug is that requesting an offset change with ScrollViewer.ChangeView would result in an incorrect offset.
Introduced a new UniformGridLayout::GetItemsPerLine to evaluate the items-per-line value.
The old evaluation was ignoring the fact that when there are N columns, there are only N-1 separators in-between them and not N. This sometimes resulted in a smaller evaluated column count in a Horizontal layout.
The key code change is "+ MinItemSpacing()".
How Has This Been Tested?
Ad-hoc testing, new MuxControlsTestApp features for UniformGridLayout test page, new unit test with that page.
Without this fix, ScrollViewer.ChangeView(...1000...) would land at offset 1216 in the new test.