Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BreadcrumbBar: remove tabstop from the bar itself #4979

Merged
merged 2 commits into from
May 8, 2021

Conversation

beervoley
Copy link
Contributor

Description

This PR removes tabStop from the BreadcrumbBar itself.

Motivation and Context

When focus comes from inside the BreadcrumbBar the control becomes focused. We don't want that - we only want the items inside to be focusable (kinda like ListView).
This PR removes the tabStop from the control itself.

How Has This Been Tested?

Manually.

@beervoley beervoley added team-Controls Issue for the Controls team area-Breadcrumb labels May 7, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label May 7, 2021
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such complex changes, much wow! Jokes aside, LGTM.

@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label May 7, 2021
@beervoley beervoley force-pushed the user/vsiliush/breadcrumb-fix-tabstop branch from 3dccd4a to cb265a0 Compare May 8, 2021 05:27
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley merged commit d7b8e9b into main May 8, 2021
@beervoley beervoley deleted the user/vsiliush/breadcrumb-fix-tabstop branch May 8, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Breadcrumb team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants