Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PersonPicture themeresources #4953

Merged
merged 5 commits into from
May 6, 2021
Merged

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented May 4, 2021

Before: (Light Theme/Dark Theme and HC)
image

After:
image

Major change:
Size from100x100 to 96x96. and font size is changed from 36 to 40, font-weight is changed from 350 to 600, Foreground color changed to TextFillColorPrimaryBrush

Because we don't use system brushes directly from controls anymore. I removed the system brush check from VerifyOverrides

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label May 4, 2021
@licanhua
Copy link
Contributor Author

licanhua commented May 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley added area-PersonPicture team-Controls Issue for the Controls team area-UIDesign UI Design, styling labels May 4, 2021
@licanhua
Copy link
Contributor Author

licanhua commented May 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label May 4, 2021
@licanhua
Copy link
Contributor Author

licanhua commented May 5, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@licanhua
Copy link
Contributor Author

licanhua commented May 5, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@licanhua licanhua merged commit ea823c0 into main May 6, 2021
@licanhua licanhua deleted the user/canhua/personpicture branch May 6, 2021 22:59
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Mar 16, 2024
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-PersonPicture area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants