Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SplitButton] Update checked flyout open background colors #4927

Conversation

marcelwgn
Copy link
Collaborator

@marcelwgn marcelwgn commented Apr 29, 2021

Description

Updates brushes to indicate that the SplitButton is checked.

Motivation and Context

Closes #4019

How Has This Been Tested?

Screenshots (if appropriate):

Checked SplitButton with flyout open in light theme
Checked SplitButton with flyout open in dark theme

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 29, 2021
@StephenLPeters
Copy link
Contributor

/azp run

@StephenLPeters StephenLPeters added area-SplitButton area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 30, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

@chigy FYUI

@StephenLPeters StephenLPeters merged commit a888c67 into microsoft:main May 4, 2021
@ghost
Copy link

ghost commented Jun 24, 2021

🎉Microsoft.UI.Xaml v2.6.0-prerelease.210623001 has been released which incorporates this pull request.:tada:

Handy links:

Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Mar 15, 2024
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-SplitButton area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToggleSplitButton's "On" state looks wrong while its flyout is open
2 participants