Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuFlyout items: Fixed icon color on press #4923

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

kimsealls
Copy link
Contributor

Description

Updated MenuFlyoutItemBackgroundPressed to MenuFlyoutItemForegroundPressed (icons are a foreground element).

Motivation and Context

Icons on press were "disappearing" due to incorrect color mapping.

How Has This Been Tested?

Validated in MUX controls test app.

Screenshots (if appropriate):

BEFORE
Before_MenuItemIcon

AFTER
After_MenuItemIcon

After_MenuItemIcon_Dark

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 29, 2021
@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ranjeshj ranjeshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ranjeshj ranjeshj merged commit 7bde310 into microsoft:main Apr 29, 2021
@StephenLPeters StephenLPeters added area-Menus area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Menus area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants