Font ramp update #4862
Merged
Font ramp update #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tashatitova
approved these changes
Apr 20, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marksfoster
removed
the
needs-triage
ranjeshj
pushed a commit
that referenced
this pull request
Apr 22, 2021
|
@marksfoster Do these changes take into account the change of font from Segoe UI to Segoe UI Variable? I can only assume there is some new logic going on under the hood to adjust the OpticalSize axis in line with the font size being used - but I wonder if that will only be supported with Windows 10 21H2 onward, or if the font will be bundled with WinUI/Reunion, so all WinUI apps will benefit from the new and more consistent typographic styles? |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 14, 2023
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in BaseTextBlockStyle which causes TextBlocks in legacy code (with style BaseTextBlockStyle) to not be SemiBold.
STYLE IN GENERIC
<Style x:Key="BaseTextBlockStyle" TargetType="TextBlock"> <Setter Property="FontFamily" Value="XamlAutoFontFamily" /> <Setter Property="FontWeight" Value="SemiBold" /> <Setter Property="FontSize" Value="14" /> <Setter Property="TextTrimming" Value="None" /> <Setter Property="TextWrapping" Value="Wrap" /> <Setter Property="LineStackingStrategy" Value="MaxHeight" /> <Setter Property="TextLineBounds" Value="Full" /> </Style>Before
After
