Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuFlyout: blurry stroke #4857

Merged
merged 1 commit into from
Apr 20, 2021
Merged

MenuFlyout: blurry stroke #4857

merged 1 commit into from
Apr 20, 2021

Conversation

beervoley
Copy link
Contributor

Description

We have a blurry stroke on menuflyout because shadow draws over the border stroke.

Motivation and Context

This PR removes the child border element of the menuflyout presenter and sets the border to be the parent element that makes it draw over the shadow properly.

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

Before:
image
After:
image

@beervoley beervoley added area-Menus team-Controls Issue for the Controls team labels Apr 19, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 19, 2021
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

marcelwgn
marcelwgn reviewed Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to backport these changes to the v1 styles? If we can easily switch to a border instead of Grid, I think it is good to do this since it is more performant on the visual tree even if there is no bug in v1 styles.

@StephenLPeters StephenLPeters added area-Flyouts and removed needs-triage Issue needs to be triaged by the area owners labels Apr 19, 2021
@beervoley
Copy link
Contributor Author

Do we need to backport these changes to the v1 styles? If we can easily switch to a border instead of Grid, I think it is good to do this since it is more performant on the visual tree even if there is no bug in v1 styles.

@ranjeshj @StephenLPeters what are your thoughts?:)

@ranjeshj ranjeshj merged commit 80a7078 into master Apr 20, 2021
@ranjeshj ranjeshj deleted the user/vsiliush/menuflyout-blurry-border-fix branch April 20, 2021 20:21
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 14, 2023
@Kinnara
Port microsoft/microsoft-ui-xaml#4857
bcec565
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 14, 2023
@Kinnara
Port microsoft/microsoft-ui-xaml#4857 (#651)
b2bd326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn left review comments

@tashatitova tashatitova tashatitova approved these changes

@StephenLPeters StephenLPeters Awaiting requested review from StephenLPeters

@ranjeshj ranjeshj Awaiting requested review from ranjeshj

@marksfoster marksfoster Awaiting requested review from marksfoster

Assignees
No one assigned
Labels
area-Flyouts area-Menus team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beervoley @marcelwgn @tashatitova @StephenLPeters @ranjeshj