-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TeachingTip: update beak placement and remove top highlight #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beervoley
requested review from
StephenLPeters,
ranjeshj,
tashatitova and
marksfoster
April 16, 2021 21:54
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure the V1 style still works? |
StephenLPeters
added
area-UIDesign
UI Design, styling
and removed
needs-triage
Issue needs to be triaged by the area owners
labels
Apr 19, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes top highlight and updates general placement of the beak (arrow looking polygon) to correctly draw rounded corners.
Motivation and Context
Previously, the corners of the teaching tip were a little "cut off" on the side where the beak was located. Now they're nice and rounded.
Top highlight was removed as design decided we do not need it anymore.
How Has This Been Tested?
Manually.
Screenshots (if appropriate):
Solid background (when lightDismissEnabled = false)
Acrylic background (when lightDismissEnabled = true)