Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeachingTip: update beak placement and remove top highlight #4846

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

beervoley
Copy link
Contributor

@beervoley beervoley commented Apr 16, 2021

Description

This PR removes top highlight and updates general placement of the beak (arrow looking polygon) to correctly draw rounded corners.

Motivation and Context

Previously, the corners of the teaching tip were a little "cut off" on the side where the beak was located. Now they're nice and rounded.
Top highlight was removed as design decided we do not need it anymore.

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

Solid background (when lightDismissEnabled = false)
image
image

Acrylic background (when lightDismissEnabled = true)
image
image

@beervoley beervoley added area-TeachingTip team-Controls Issue for the Controls team labels Apr 16, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 16, 2021
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley requested a review from karkarl April 16, 2021 21:58
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters
Copy link
Contributor

Can you make sure the V1 style still works?

@StephenLPeters StephenLPeters added area-UIDesign UI Design, styling and removed needs-triage Issue needs to be triaged by the area owners labels Apr 19, 2021
@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley merged commit 3b6deb2 into master Apr 21, 2021
@beervoley beervoley deleted the user/vsiliush/teachingtip-visual-update branch April 21, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TeachingTip area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants