Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing WACK failure on store submission #4820

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

llongley
Copy link
Member

The store expectations for WACK certification are somewhat finicky - they need a WinMD to appear in the WinMetadata folder (and in the root) when that WinMD is implemented by a framework package (which is the case for our stable releases), but they need that WinMD to not appear in the WinMetadata folder when that WinMD is implemented by a DLL in the AppX file (which is the case for our prereleases).

Frustratingly, this restriction appears to only be enforced when actually submitting to the store - the local app cert kit does not report any issues; it's only when you upload the appxupload/msixupload file to the store that it complains. Additionally, there does not appear to be any way to locally run validation on that appxupload/msixupload file, so there's no way for me to add a check to ensure that we won't hit this in the future. I've manually uploaded a test app built with these changes and submitted it to the store, and confirmed that it passed certification there.

There's also a separate item group for items to be added to the appxupload/msixupload file, which also needs to have our WinMD added to it. I've done that, too.

Fixes #3780

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 15, 2021
@llongley
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley added team-Controls Issue for the Controls team area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency labels Apr 15, 2021
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Store App Certification Fails after upgrading Microsoft.UI.XAML to v2.5.0
4 participants