-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SplitButton style for CommandBar #4817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beervoley
added
area-Commanding
AppBar, UICommand, MVVM, etc
team-Controls
Issue for the Controls team
labels
Apr 14, 2021
StephenLPeters
removed
the
needs-triage
Issue needs to be triaged by the area owners
label
Apr 14, 2021
It's a SplitButton and behaves like a SplitButton, with two hit targets -- this is just a retemplate of SplitButton to look good in CommandBar. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
approved these changes
Apr 19, 2021
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 13, 2023
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables SplitButton to look like an AppBarButton in CommandBar, even though it isn't. I essentially copied the default SplitButton template and replaced all the colors, removed the dividing line between the two sides of the button, and adjusted the size/margins.