Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SplitButton style for CommandBar #4817

Merged
merged 6 commits into from
Apr 19, 2021
Merged

Conversation

teaP
Copy link
Contributor

@teaP teaP commented Apr 14, 2021

image

This change enables SplitButton to look like an AppBarButton in CommandBar, even though it isn't. I essentially copied the default SplitButton template and replaced all the colors, removed the dividing line between the two sides of the button, and adjusted the size/margins.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 14, 2021
@mdtauk
Copy link
Contributor

mdtauk commented Apr 14, 2021

So it is functionally a button, but it has a chevron? Or is the chevron and button two separate hit-targets, and it behaves like a SplitButton?

If it is functionally a button, then its a DropDownButton surely, rather than a SplitButton.

image

@beervoley beervoley added area-Commanding AppBar, UICommand, MVVM, etc team-Controls Issue for the Controls team labels Apr 14, 2021
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Apr 14, 2021
@teaP
Copy link
Contributor Author

teaP commented Apr 15, 2021

So it is functionally a button, but it has a chevron? Or is the chevron and button two separate hit-targets, and it behaves like a SplitButton?

It's a SplitButton and behaves like a SplitButton, with two hit targets -- this is just a retemplate of SplitButton to look good in CommandBar.

@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@teaP teaP merged commit e22113f into master Apr 19, 2021
@teaP teaP deleted the user/teaP/SplitButtonStyles branch April 19, 2021 19:06
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 13, 2023
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Commanding AppBar, UICommand, MVVM, etc team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants