Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContentDialog] Fix title margin & fontweight and corners #4809

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Apr 13, 2021

Fix corners, title font weight and margin between title and top border

Description

  • Fixes CornerRadius properties for inner grids
  • Sets the title fontweight to SemiBold
  • Changes margin to 21 to match the visual design

Motivation and Context

VSO: 32303725

How Has This Been Tested?

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 13, 2021
@StephenLPeters StephenLPeters added area-Dialogs area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 13, 2021
@almedina-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almedina-ms almedina-ms merged commit d51d7a1 into master Apr 19, 2021
@almedina-ms almedina-ms deleted the user/almedina-ms/ContentDialog_VisualUpdated branch April 19, 2021 18:38
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 11, 2023
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants