Navigation View Layout Reflow #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
added
area-NavigationView
beervoley
reviewed
Apr 12, 2021
beervoley
reviewed
Apr 12, 2021
beervoley
reviewed
Apr 12, 2021
beervoley
reviewed
Apr 12, 2021
beervoley
reviewed
Apr 12, 2021
| <StaticResource x:Key="NavigationViewItemForeground" ResourceKey="TextFillColorPrimaryBrush" /> | ||
| <StaticResource x:Key="NavigationViewItemForegroundPointerOver" ResourceKey="TextFillColorPrimaryBrush" /> | ||
| <StaticResource x:Key="NavigationViewItemForeground" ResourceKey="TextFillColorSecondaryBrush" /> | ||
| <StaticResource x:Key="NavigationViewItemForegroundPointerOver" ResourceKey="TextFillColorSecondaryBrush" /> | ||
| <StaticResource x:Key="NavigationViewItemForegroundPressed" ResourceKey="TextFillColorSecondaryBrush" /> |
There was a problem hiding this comment.
In dark theme NavigationViewItemForegroundPointerOver this brush is using TextFillColorPrimary, is that expected?
There was a problem hiding this comment.
Both dark theme and light theme is using TextFillcolorSecondaryBrush for NavigationViewItemForegroundPointerOver ?
There was a problem hiding this comment.
I meant NavigationViewItemForegroundPressed :)
Dark:
Light:
There was a problem hiding this comment.
Oh yes, good catch!
There was a problem hiding this comment.
@karenbtlai it's still here :)
beervoley
reviewed
Apr 12, 2021
StephenLPeters
removed
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
approved these changes
Apr 22, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
22 tasks
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 15, 2023
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update NavigationView to be up to specification.
Motivation and Context
How Has This Been Tested?
Visual verification and cross checking with designer.
Screenshots (if appropriate):