TeachingTip: close button update #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beervoley
added
area-TeachingTip
area-UIDesign
ghost
added
the
beervoley
requested review from
StephenLPeters,
tashatitova,
ranjeshj and
karkarl
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tashatitova
reviewed
Apr 9, 2021
marksfoster
reviewed
Apr 9, 2021
marksfoster
reviewed
Apr 9, 2021
tashatitova
approved these changes
Apr 9, 2021
marksfoster
approved these changes
Apr 9, 2021
StephenLPeters
removed
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Not merging until decision about Teaching Tip api change is made. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates close button of the teaching tip. And adjusts margin of the active buttons.
Motivation and Context
The colors of the close button were not correct for hover and pressed states as well as size of the icon and padding.
I've also reduced the space between active and close button when they're next to each other.
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Rest:
Hover:
Pressed:
Margin before:
Margin after: