Binding CornerRadius to CommandBar.CornerRadius #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-Commanding
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 7, 2023
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CornerRadius is hard coded ControlCornerRadius. If CommandBar.CornerRadius is supported, we should use CommandBar.CornerRadius
CornerRadius = 2 when CommandBar.IsOpen=true
CornerRadius=10 when CommandBar.IsOpen=true
CornerRadius=2/10 when CommandBar.IsOpen=false. The CommandBar background is transparent.
Known issue:
If the commandbar has background like Red and IsOpen=false, CornerRadius is not supported.
But IsOpen=true, we support CornerRadius.
CommandBar used Clip to clip the unsupported area, so half of the corner radius will be clipped, so it's hard to support CornerRadius when IsOpen=false.