Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BreadcrumbBar] Add theme resource keys for customizing Chevron padding and font weight #4727

Merged
merged 45 commits into from
Apr 9, 2021

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Apr 2, 2021

Description

Adds an extra TextBlock item that is only shown when the element is the last item, that way we avoid changing between the different visual states as well as raising click events

Add the following theme resources:

  • BreadcrumbBarChevronFontSize: Double value that determines the Chevron size (the arrow after every node)
  • BreadcrumbBarChevronPadding: Thickness value that determines the padding between the chevron and the content for the associated and the next breadcrumb item
  • BreadcrumbBarItemFontWeight: FontWeight value that determines the font weight of the BreadcrumbItems that are not drop down items, including the CurrentItem font weight

Motivation and Context

VSO bug: 32260502

How Has This Been Tested?

To verify that the customization properties have been applied, this snippet was added (but not merged) to the BreadcrumbBarPage:

<Page.Resources>
        <ResourceDictionary>
            <ResourceDictionary.ThemeDictionaries>

                <ResourceDictionary x:Key="Default">
                    <SolidColorBrush x:Key="BreadcrumbBarNormalForegroundBrush" Color="DarkGray"/>
                    <SolidColorBrush x:Key="BreadcrumbBarCurrentNormalForegroundBrush" Color="Black"/>

                    <x:Double x:Key="BreadcrumbBarChevronFontSize">20</x:Double>
                    <x:Double x:Key="BreadcrumbBarItemThemeFontSize">20</x:Double>
                    <Thickness x:Key="BreadcrumbBarChevronPadding">10,0</Thickness>

                    <FontWeight x:Key="BreadcrumbBarItemFontWeight">Semibold</FontWeight>
                </ResourceDictionary>

                <ResourceDictionary x:Key="Light">
                    <SolidColorBrush x:Key="BreadcrumbBarNormalForegroundBrush" Color="DarkGray"/>
                    <SolidColorBrush x:Key="BreadcrumbBarCurrentNormalForegroundBrush" Color="Black"/>

                    <x:Double x:Key="BreadcrumbBarChevronFontSize">20</x:Double>
                    <x:Double x:Key="BreadcrumbBarItemThemeFontSize">20</x:Double>
                    <Thickness x:Key="BreadcrumbBarChevronPadding">10,0</Thickness>

                    <FontWeight x:Key="BreadcrumbBarItemFontWeight">Semibold</FontWeight>
                </ResourceDictionary>

                <ResourceDictionary x:Key="HighContrast">
                </ResourceDictionary>
            </ResourceDictionary.ThemeDictionaries>
        </ResourceDictionary>
    </Page.Resources>

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 2, 2021
@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Apr 2, 2021
@ranjeshj
Copy link
Contributor

ranjeshj commented Apr 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almedina-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almedina-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almedina-ms
Copy link
Contributor Author

/azp

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@RBrid
Copy link
Contributor

RBrid commented Apr 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almedina-ms almedina-ms merged commit f4a2812 into master Apr 9, 2021
@almedina-ms almedina-ms deleted the user/almedina-ms/BC_CustomizeChevronMargins branch April 9, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Breadcrumb team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants