-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BreadcrumbBar] Add theme resource keys for customizing Chevron padding and font weight #4727
Merged
almedina-ms
merged 45 commits into
master
from
user/almedina-ms/BC_CustomizeChevronMargins
Apr 9, 2021
Merged
[BreadcrumbBar] Add theme resource keys for customizing Chevron padding and font weight #4727
almedina-ms
merged 45 commits into
master
from
user/almedina-ms/BC_CustomizeChevronMargins
Apr 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BC_ChangeLastItemForTextBlock
…dina-ms/BC_ChangeLastItemForTextBlock
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…er/almedina-ms/BC_CustomizeChevronMargins
…er/almedina-ms/BC_CustomizeChevronMargins
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp |
Supported commands
See additional documentation. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an extra TextBlock item that is only shown when the element is the last item, that way we avoid changing between the different visual states as well as raising click events
Add the following theme resources:
Motivation and Context
VSO bug: 32260502
How Has This Been Tested?
To verify that the customization properties have been applied, this snippet was added (but not merged) to the BreadcrumbBarPage: